Skip to content

Fix JarFileTests.getInputStreamWhenClosed() #21365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix JarFileTests.getInputStreamWhenClosed() #21365

wants to merge 1 commit into from

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented May 8, 2020

This PR fixes JarFileTests.getInputStreamWhenClosed() as the assertion was passing due to this.jarFile.getEntry(), not this.jarFile.getInputStream() that was intended to assert in the test.

@snicoll snicoll self-assigned this May 8, 2020
@snicoll snicoll added the type: task A general task label May 8, 2020
@snicoll snicoll added this to the 2.3.0 milestone May 8, 2020
@snicoll
Copy link
Member

snicoll commented May 8, 2020

Good catch!

snicoll pushed a commit that referenced this pull request May 8, 2020
@izeye @snicoll
Fix JarFileTests.getInputStreamWhenClosed()
665a127 
See gh-21365
@snicoll snicoll closed this in 228703f May 8, 2020
@izeye izeye deleted the get-input-stream branch May 8, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: task A general task

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@izeye @snicoll